-
Notifications
You must be signed in to change notification settings - Fork 224
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade macOS build to macOS 14 #3297
Conversation
446a6de
to
d238e12
Compare
* This will also build on arm runners * Switches build directory to more standard location on Apple silicon macs * Updates to use virtual environment for python as per https://docs.brew.sh/Python-for-Formula-Authors#python-declarations-for-applications
d238e12
to
1e3843b
Compare
Still needs testing on macOS. |
Ok. Client and server run on macOS. But #3287 shows up and may be even worse: I cannot register to a directory on macOS at all! |
@pljones I believe this is only a minor change (even though the build architecture changed). It runs on macOS non legacy Intel as expected. The build times may decrease. |
Co-authored-by: Peter L Jones <pljones@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Changes look reasonable and the CI build succeeds.
Just wanted to add a point of interest. I just tried rebasing and running a test build of mine that runs CodeQL on the main Mac build instead of on the legacy build. It would appear that CodeQL can't be enabled on the ARM runner. At least maybe not without other changes. See https://github.com/softins/jamulus/actions/runs/9874046539 |
I think it's not ARM but rather code signing. We moved codeql to legacy once in the past. |
CodeQL for Mac currently is on legacy, and has been for a long time. I was just experimenting with moving it back to the main build, which worked after the The error messages on the run I linked to above suggest that the problem is with the ARM building environment, not the signing. Something to do with Rosetta. But it's not a big problem to leave it as it is; I just thought it was good for us to be aware of the limitation. |
Short description of changes
CHANGELOG: Build: Upgrade main macOS build to macOS 14 and Apple Silicon build
Context: Fixes an issue?
Fixes: #3296
Does this change need documentation? What needs to be documented and how?
No
Status of this Pull Request
Ready for testing
What is missing until this pull request can be merged?
Review and test
Checklist